Shawn Xu
66aee01bb1
Simplify Return Value Adjustment Condition
...
Passed Non-regression STC:
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 82112 W: 21281 L: 21110 D: 39721
Ptnml(0-2): 258, 9630, 21112, 9795, 261
https://tests.stockfishchess.org/tests/view/67c42528b7226b5d8a2dd3a0
Passed Non-regression LTC:
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 182652 W: 46295 L: 46240 D: 90117
Ptnml(0-2): 103, 20025, 51003, 20104, 91
https://tests.stockfishchess.org/tests/view/67c4d56b685e87e15e7c43d8
closes https://github.com/official-stockfish/Stockfish/pull/5925
Bench: 1711791
2025-03-21 11:11:12 +01:00
Daniel Monroe
f9a6d43286
Simplify condition in futility pruning
...
Passed STC
LLR: 2.93 (-2.94,2.94) <-1.75,0.25>
Total: 427040 W: 111061 L: 111271 D: 204708
Ptnml(0-2): 1709, 48524, 113171, 48500, 1616
https://tests.stockfishchess.org/tests/view/67af01d01a4c73ae1f930ea4
Passed rebased LTC
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 28704 W: 7330 L: 7120 D: 14254
Ptnml(0-2): 8, 3000, 8138, 3186, 20
https://tests.stockfishchess.org/tests/view/67ca629a45214989aa0a123e
closes https://github.com/official-stockfish/Stockfish/pull/5924
Bench: 2050046
2025-03-21 11:09:38 +01:00
Shawn Xu
e3660b47bd
Add dbg_clear helper function
...
closes https://github.com/official-stockfish/Stockfish/pull/5921
No functional change
2025-03-21 11:09:28 +01:00
Carlos Esparza
e407a4f269
Simplify risk_tolerance + avoid overflow
...
passed simplification STC:
LLR: 2.93 (-2.94,2.94) <-1.75,0.25>
Total: 73984 W: 19058 L: 18879 D: 36047
Ptnml(0-2): 232, 8735, 18866, 8940, 219
https://tests.stockfishchess.org/tests/view/67c269a38200cf1034c9baf9
passed simplification LTC:
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 39288 W: 10033 L: 9833 D: 19422
Ptnml(0-2): 14, 4168, 11086, 4356, 20
https://tests.stockfishchess.org/tests/view/67c34f8c8200cf1034c9bda1
closes https://github.com/official-stockfish/Stockfish/pull/5919
Bench: 2050046
2025-03-21 11:09:27 +01:00
Shawn Xu
b825ea6e57
Improve Perft Testing
...
Added #5909 problematic position and chess-library DFRC positions to
perft testing. Additional work done by @Disservin to clean up and
improve error reporting.
closes https://github.com/official-stockfish/Stockfish/pull/5917
No functional change
Co-authored-by: disservin <disservin.social@gmail.com >
2025-03-21 11:03:31 +01:00
Shawn Xu
99d32e395e
Reapply #5909
...
This version fixes the logic of `gives_check`, which was identified to
be the cause of illegal moves.
closes https://github.com/official-stockfish/Stockfish/pull/5914
No functional change
Co-authored-by: Robert Nürnberg <robert.nurnberg@gmx.de >
Co-authored-by: gab8192 <gabrilomba57@gmail.com >
2025-03-21 11:02:19 +01:00
xu-shawn
f3bfce3531
Revert "Replace aligned() function with line_bb() and simplify king piece detection" ( #5915 )
...
closes https://github.com/official-stockfish/Stockfish/pull/5915
No functional change
Co-authored-by: Robert Nürnberg <robert.nurnberg@gmx.de >
2025-02-28 09:50:59 +01:00
FauziAkram
5c617e579c
VVLTC Search Tune
...
Passed VVLTC with STC bounds:
LLR: 2.94 (-2.94,2.94) <0.00,2.00>
Total: 15788 W: 4106 L: 3868 D: 7814
Ptnml(0-2): 0, 1324, 5009, 1560, 1
https://tests.stockfishchess.org/tests/view/67bf2ddd6e569f6234102ade
Passed VVLTC with LTC bounds:
LLR: 2.95 (-2.94,2.94) <0.50,2.50>
Total: 13622 W: 3620 L: 3368 D: 6634
Ptnml(0-2): 3, 1190, 4170, 1448, 0
https://tests.stockfishchess.org/tests/view/67c04308c8f7c4c0632d8055
closes https://github.com/official-stockfish/Stockfish/pull/5910
Bench: 1823605
2025-02-27 20:40:56 +01:00
Jake Senne
6d9c6f99b9
Replace aligned() function with line_bb() and simplify king piece detection
...
From https://discord.com/channels/435943710472011776/813919248455827515/1342267241168900228
Saves 6 instructions
closes https://github.com/official-stockfish/Stockfish/pull/5909
No functional change
2025-02-27 20:38:03 +01:00
FauziAkram
a730b4d08b
Remove two unnecessary divisions
...
Passed STC:
LLR: 2.93 (-2.94,2.94) <-1.75,0.25>
Total: 280768 W: 72187 L: 72236 D: 136345
Ptnml(0-2): 815, 33131, 72550, 33064, 824
https://tests.stockfishchess.org/tests/view/67bcf7afe670525923b8a101
Passed LTC:
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 108684 W: 27666 L: 27536 D: 53482
Ptnml(0-2): 40, 11768, 30606, 11878, 50
https://tests.stockfishchess.org/tests/view/67be472ed8d5c2c657c52cb8
closes https://github.com/official-stockfish/Stockfish/pull/5908
Bench: 2400689
2025-02-27 20:34:49 +01:00
Shawn Xu
09faa62621
Simplify NMP Conditions
...
Passed Non-regression STC:
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 142400 W: 36883 L: 36779 D: 68738
Ptnml(0-2): 467, 16804, 36571, 16874, 484
https://tests.stockfishchess.org/tests/view/67bd1898e4a8d7152b974ef1
Passed Non-regression LTC:
LLR: 2.95 (-2.94,2.94) <-1.75,0.25>
Total: 251868 W: 63905 L: 63920 D: 124043
Ptnml(0-2): 133, 27480, 70708, 27495, 118
https://tests.stockfishchess.org/tests/view/67bd1898e4a8d7152b974ef1
closes https://github.com/official-stockfish/Stockfish/pull/5906
Bench: 2188400
2025-02-27 20:31:04 +01:00
mstembera
e4d7136042
Combine last 3 add/remove operations
...
https://tests.stockfishchess.org/tests/view/67ad587052879dfd14d7e8a5
LLR: 2.95 (-2.94,2.94) <0.00,2.00>
Total: 45856 W: 12177 L: 11855 D: 21824
Ptnml(0-2): 176, 4845, 12588, 5119, 200
The two most common cases are when added and removed counts are equal
and when they are off by 1. When they are off by 1 we currently do a
pass combining 2 and then an extra pass for the last 1. This patch does
a single combined pass on the final 3 instead. Tested on top of the
simplification in
https://github.com/official-stockfish/Stockfish/pull/5901
closes https://github.com/official-stockfish/Stockfish/pull/5902
No functional change
2025-02-27 20:30:44 +01:00
mstembera
d330b48e21
Handle updating the small accumulator the same way as the big one
...
https://tests.stockfishchess.org/tests/view/67abfe1ca04df5eb8dbebf0b
LLR: 2.97 (-2.94,2.94) <-1.75,0.25>
Total: 153088 W: 40072 L: 39979 D: 73037
Ptnml(0-2): 619, 16728, 41764, 16807, 626
closes https://github.com/official-stockfish/Stockfish/pull/5901
No functional change
2025-02-27 20:30:10 +01:00
FauziAkram
93b966829b
Simplify bestvalue update formula
...
Passed STC:
LLR: 2.95 (-2.94,2.94) <-1.75,0.25>
Total: 124960 W: 32598 L: 32472 D: 59890
Ptnml(0-2): 480, 14852, 31694, 14970, 484
https://tests.stockfishchess.org/tests/view/67b348bae00eea114cdba37d
Passed LTC:
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 150306 W: 38220 L: 38132 D: 73954
Ptnml(0-2): 98, 16430, 42005, 16526, 94
https://tests.stockfishchess.org/tests/view/67b5e37918a66624a7a3f751
closes https://github.com/official-stockfish/Stockfish/pull/5898
Bench: 2146010
2025-02-24 19:16:26 +01:00
Joost VandeVondele
0f9ae0d11c
Check maximum time every iteration
...
This fixes a TCEC timeloss, where slow DTZ TB7 access, in combination
with syzygy PV extension, led to a timeloss.
While the extension code correctly aborted after spending moveOverhead/2
time, the mainThread did not search sufficient nodes (512 in > 1s) to
trigger the stop in check_time. At the same time, totalTime exceeded
tm.maximum() due to the factors multiplying tm.optimum().
This corner case is fixed by checking also against the tm.maximum() at
each iteration.
Even though this problem can't be triggered on fishtest, the patch was
verified there.
Passed STC:
https://tests.stockfishchess.org/tests/view/67b99e1be99f8640b318810d
LLR: 2.93 (-2.94,2.94) <-1.75,0.25>
Total: 136832 W: 35625 L: 35518 D: 65689
Ptnml(0-2): 499, 14963, 37431, 14978, 545
closes https://github.com/official-stockfish/Stockfish/pull/5896
No functional change
2025-02-24 19:15:32 +01:00
Michael Chaly
c19a6ea53c
Make Pv search shallower in some cases
...
Conditions are the same as they are for doShallowerSearch, just that
they also apply for cases where LMR wasn't reducing anything - if result
is bad enough reduce search depth of PV search by 1.
Passed STC:
https://tests.stockfishchess.org/tests/view/67b9d2aca49c651c2caac818
LLR: 2.95 (-2.94,2.94) <0.00,2.00>
Total: 29216 W: 7731 L: 7424 D: 14061
Ptnml(0-2): 87, 3345, 7473, 3580, 123
Passed LTC:
https://tests.stockfishchess.org/tests/view/67ba538c01f3463ae1d35e69
LLR: 2.94 (-2.94,2.94) <0.50,2.50>
Total: 33168 W: 8529 L: 8219 D: 16420
Ptnml(0-2): 12, 3505, 9262, 3771, 34
closes https://github.com/official-stockfish/Stockfish/pull/5895
Bench: 2290732
2025-02-24 19:14:04 +01:00
Myself
57f0fe08c0
Add risk tolerance calculation
...
https://tests.stockfishchess.org/tests/view/67b1db2188b11e2400eb06ae
Passed STC:
LLR: 2.93 (-2.94,2.94) <0.00,2.00>
Total: 123552 W: 32388 L: 31938 D: 59226
Ptnml(0-2): 487, 14520, 31345, 14904, 520
Passed LTC:
https://tests.stockfishchess.org/tests/view/67b3d53f154c4df4fc4b1f43
LLR: 2.95 (-2.94,2.94) <0.50,2.50>
Total: 206928 W: 52916 L: 52246 D: 101766
Ptnml(0-2): 159, 22546, 57394, 23196, 169
closes https://github.com/official-stockfish/Stockfish/pull/5893
Bench: 2705449
2025-02-24 19:12:35 +01:00
Disservin
291a429cdd
Remove duplicated info string printing
...
Currently "info string" is being printed twice for the network arch
```
info string info string NNUE evaluation using nn-1c0000000000.nnue (133MiB, (22528, 3072, 15, 32, 1))
info string info string NNUE evaluation using nn-37f18f62d772.nnue (6MiB, (22528, 128, 15, 32, 1))
```
closes https://github.com/official-stockfish/Stockfish/pull/5889
No functional change
2025-02-24 19:10:38 +01:00
Shawn Xu
43b2d65d72
Add scaling note to futility pruning
...
Note that both patches below effectively reduces the frequency of futility pruning.
Passed STC:
LLR: 2.94 (-2.94,2.94) <0.00,2.00>
Total: 51680 W: 13599 L: 13253 D: 24828
Ptnml(0-2): 217, 6056, 12959, 6380, 228
https://tests.stockfishchess.org/tests/view/67ac218fa04df5eb8dbebf26
Passed LTC:
LLR: 2.94 (-2.94,2.94) <0.50,2.50>
Total: 51798 W: 13338 L: 12986 D: 25474
Ptnml(0-2): 42, 5584, 14310, 5906, 57
https://tests.stockfishchess.org/tests/view/67acf04152879dfd14d7e846
Regression at STC SMP:
LLR: 2.94 (-2.94,2.94) <0.00,2.00>
Total: 231552 W: 60226 L: 59642 D: 111684
Ptnml(0-2): 565, 25994, 62031, 26664, 522
https://tests.stockfishchess.org/tests/view/67ae390c1a4c73ae1f930dbf
Passed STC:
LLR: 2.93 (-2.94,2.94) <0.00,2.00>
Total: 22560 W: 6022 L: 5725 D: 10813
Ptnml(0-2): 87, 2524, 5762, 2819, 88
https://tests.stockfishchess.org/tests/view/67ac202aa04df5eb8dbebf22
Passed LTC:
LLR: 2.95 (-2.94,2.94) <0.50,2.50>
Total: 66138 W: 16953 L: 16572 D: 32613
Ptnml(0-2): 62, 7103, 18360, 7480, 64
https://tests.stockfishchess.org/tests/view/67ad47d852879dfd14d7e899
Regression at VVLTC SMP:
LLR: -2.94 (-2.94,2.94) <-1.75,0.25>
Total: 29138 W: 7408 L: 7655 D: 14075
Ptnml(0-2): 0, 2816, 9189, 2559, 5
https://tests.stockfishchess.org/tests/view/67b159ce6c6b9e172ad1598f
closes https://github.com/official-stockfish/Stockfish/pull/5888
No functional change
2025-02-24 19:09:52 +01:00
Nonlinear2
fc2139fedc
se separate parameters for stat values
...
The code has been refactored to remove the `stat_bonus` and `stat_malus`
functions, as the code for each bonus/malus is now different. This
allows for future tests to modify these formulas individually.
Passed LTC with STC bounds:
https://tests.stockfishchess.org/tests/view/67b115dd6c6b9e172ad1592f
LLR: 2.94 (-2.94,2.94) <0.00,2.00>
Total: 75756 W: 19393 L: 19044 D: 37319
Ptnml(0-2): 60, 8251, 20913, 8588, 66
Passed LTC with LTC bounds:
https://tests.stockfishchess.org/tests/view/67af5f5d6c6b9e172ad15765
LLR: 2.94 (-2.94,2.94) <0.50,2.50>
Total: 108126 W: 27880 L: 27412 D: 52834
Ptnml(0-2): 85, 11786, 29866, 12228, 98
closes https://github.com/official-stockfish/Stockfish/pull/5887
Bench: 2809143
2025-02-24 19:09:28 +01:00
Daniel Monroe
45b2b06cea
Use same term for small and large net for nnue complexity adjustment
...
Passed simplification STC
LLR: 2.96 (-2.94,2.94) <-1.75,0.25>
Total: 386496 W: 100682 L: 100850 D: 184964
Ptnml(0-2): 1686, 46399, 97218, 46287, 1658
https://tests.stockfishchess.org/tests/view/67a9cc6d851bb0f25324449e
Passed rebased simplification LTC
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 160884 W: 41090 L: 41012 D: 78782
Ptnml(0-2): 133, 17883, 44321, 17983, 122
https://tests.stockfishchess.org/tests/view/67aef2e91a4c73ae1f930e85
closes https://github.com/official-stockfish/Stockfish/pull/5886
Bench: 2962718
2025-02-24 19:07:58 +01:00
FauziAkram
095d19afea
Use neon_m128_reduce_add_epi32 for NEON vector reduction
...
Accomplishing the entire horizontal addition in a single NEON instruction
closes https://github.com/official-stockfish/Stockfish/pull/5885
No functional change
2025-02-24 19:07:29 +01:00
FauziAkram
ee7259e48b
Small code cleanup
...
Use std::is_arithmetic_v as it is the more modern and concise way to
check for arithmetic types. While at it, fixing a static assert in
misc.h, thanks to Shawn and Disservin for helping.
closes https://github.com/official-stockfish/Stockfish/pull/5883
No functional change
2025-02-24 19:04:59 +01:00
Daniel Monroe
76c319f438
Simplify ttcut depth condition
...
Simplify ttcut depth condition in a recent tweak of Nonlinear (PR #5876 )
Passed simplification STC
LLR: 2.95 (-2.94,2.94) <-1.75,0.25>
Total: 235328 W: 61646 L: 61644 D: 112038
Ptnml(0-2): 1039, 27947, 59676, 27977, 1025
https://tests.stockfishchess.org/tests/view/67abc7fba04df5eb8dbeb442
Passed simplification LTC
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 63744 W: 16306 L: 16128 D: 31310
Ptnml(0-2): 58, 6918, 17748, 7084, 64
https://tests.stockfishchess.org/tests/view/67abd776a04df5eb8dbeb9c1
closes https://github.com/official-stockfish/Stockfish/pull/5877
Bench: 2667779
2025-02-24 19:03:19 +01:00
Carlos Esparza
e9997afb1c
Replace hint_common_parent_position() by backwards accumulator updates
...
Only calls to `evaluate()` now trigger NNUE accumulator updates. To make
sure that we are likely to find parent positions from which to update
the accumulators we perform a backwards NNUE update whenever we compute
the accumulator from scratch for some position.
passed STC
LLR: 2.93 (-2.94,2.94) <0.00,2.00>
Total: 39680 W: 10474 L: 10164 D: 19042
Ptnml(0-2): 171, 4068, 11042, 4398, 161
https://tests.stockfishchess.org/tests/view/67a27f26eb183d11c65945be
passed LTC
LLR: 2.94 (-2.94,2.94) <0.50,2.50>
Total: 337308 W: 86408 L: 85550 D: 165350
Ptnml(0-2): 276, 30551, 106126, 31441, 260
https://tests.stockfishchess.org/tests/view/67a287efeb183d11c65945ee
then simplified:
STC
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 28608 W: 7641 L: 7413 D: 13554
Ptnml(0-2): 132, 3036, 7744, 3256, 136
https://tests.stockfishchess.org/tests/view/67a4703719f522d3866d3345
LTC
LLR: 2.96 (-2.94,2.94) <-1.75,0.25>
Total: 200226 W: 51026 L: 50990 D: 98210
Ptnml(0-2): 170, 18468, 62799, 18508, 168
https://tests.stockfishchess.org/tests/view/67a4f255229c1a170cc08964
The version in this PR is a bit different from the simplified version,
but it's compile-time changes only.
closes https://github.com/official-stockfish/Stockfish/pull/5870
No functional change
2025-02-24 19:01:23 +01:00
FauziAkram
fa6c30af81
FutilityValue formula tweak
...
Passed STC:
LLR: 2.95 (-2.94,2.94) <0.00,2.00>
Total: 29600 W: 7979 L: 7662 D: 13959
Ptnml(0-2): 138, 3446, 7324, 3745, 147
https://tests.stockfishchess.org/tests/view/67ac7dff52879dfd14d7e7da
Passed LTC:
LLR: 2.95 (-2.94,2.94) <0.50,2.50>
Total: 49662 W: 12850 L: 12502 D: 24310
Ptnml(0-2): 41, 5354, 13689, 5710, 37
https://tests.stockfishchess.org/tests/view/67acc1b252879dfd14d7e81d
closes https://github.com/official-stockfish/Stockfish/pull/5879
Bench: 2581469
2025-02-13 20:18:35 +01:00
Daniel Monroe
d54240c50a
Decrease lmr depth if static eval decreases a lot
...
This tweak originally had some more conditions which have been simplified away.
Passed STC
LLR: 2.93 (-2.94,2.94) <0.00,2.00>
Total: 60064 W: 15797 L: 15439 D: 28828
Ptnml(0-2): 236, 7080, 15106, 7310, 300
https://tests.stockfishchess.org/tests/view/67a2af9cfedef70e42ac3325
Passed LTC
LLR: 2.94 (-2.94,2.94) <0.50,2.50>
Total: 76794 W: 19740 L: 19337 D: 37717
Ptnml(0-2): 61, 8327, 21236, 8694, 79
https://tests.stockfishchess.org/tests/view/67a2c904fedef70e42ac374d
Passed Non-Regression VVLTC scaling check
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 29046 W: 7581 L: 7389 D: 14076
Ptnml(0-2): 2, 2557, 9213, 2749, 2
https://tests.stockfishchess.org/tests/view/67a54b591c4a3ea87241cb83
Passed simplification STC
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 212448 W: 55244 L: 55217 D: 101987
Ptnml(0-2): 932, 25283, 53707, 25430, 872
https://tests.stockfishchess.org/tests/view/67aaacb02554387b116f698f
Passed simplification LTC
LLR: 2.95 (-2.94,2.94) <-1.75,0.25>
Total: 185736 W: 47270 L: 47217 D: 91249
Ptnml(0-2): 141, 20568, 51394, 20627, 138
https://tests.stockfishchess.org/tests/view/67ab8efa133d55b1d3bc1397
closes https://github.com/official-stockfish/Stockfish/pull/5878
Bench: 2512420
2025-02-13 20:17:26 +01:00
Nonlinear2
a4edacb87a
Tweak the cutnode depth condition for TT cutoffs
...
Passed STC:
https://tests.stockfishchess.org/tests/view/67ab396ab5c93ee812d851f3
LLR: 2.96 (-2.94,2.94) <0.00,2.00>
Total: 83648 W: 21964 L: 21571 D: 40113
Ptnml(0-2): 339, 9779, 21217, 10128, 361
Passed LTC:
https://tests.stockfishchess.org/tests/view/67ab9647133d55b1d3bc171e
LLR: 2.94 (-2.94,2.94) <0.50,2.50>
Total: 68160 W: 17551 L: 17166 D: 33443
Ptnml(0-2): 62, 7353, 18870, 7728, 67
closes https://github.com/official-stockfish/Stockfish/pull/5876
Bench: 3087275
2025-02-13 19:52:06 +01:00
Michael Chaly
9cc15b3049
Do more reductions for cut nodes without a tt move
...
Logic is somewhat similar to IIR but in LMR.
Usually things like reducing more in IIR scale badly but this patch does
this in LMR where reducing more for cutNodes is in general good, so I
believe there is no non-linear scaling.
Passed STC:
https://tests.stockfishchess.org/tests/view/67abc9aaa04df5eb8dbeb452
LLR: 2.93 (-2.94,2.94) <0.00,2.00>
Total: 42304 W: 11223 L: 10892 D: 20189
Ptnml(0-2): 184, 4904, 10669, 5187, 208
Passed LTC:
https://tests.stockfishchess.org/tests/view/67abcd7ba04df5eb8dbeb96c
LLR: 2.95 (-2.94,2.94) <0.50,2.50>
Total: 32334 W: 8386 L: 8074 D: 15874
Ptnml(0-2): 26, 3446, 8916, 3748, 31
closes https://github.com/official-stockfish/Stockfish/pull/5875
Bench: 2612849
2025-02-13 19:49:54 +01:00
Stefan Geschwentner
7258567804
Refactor reduction rules
...
Refactor reduction rules so that all ttPv/Pv related stuff is in one
rule and the scaling becomes more clear. No functional change
closes https://github.com/official-stockfish/Stockfish/pull/5871
No functional change
2025-02-13 19:46:53 +01:00
Daniel Monroe
3a0418c0d0
Simplify opponent worsening
...
Passed simplification STC
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 57120 W: 14712 L: 14526 D: 27882
Ptnml(0-2): 53, 6241, 15796, 6407, 63
https://tests.stockfishchess.org/tests/view/67a26153eb183d11c659454d
Passed simplification LTC
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 313452 W: 79893 L: 79973 D: 153586
Ptnml(0-2): 279, 35053, 86156, 34945, 293
https://tests.stockfishchess.org/tests/view/67a29fe0fedef70e42ac32ae
closes https://github.com/official-stockfish/Stockfish/pull/5867
Bench: 2582245
2025-02-13 19:45:55 +01:00
Carlos Esparza
e089f723d8
Remove two xors by setting the hash keys for unreachable squares to zero
...
performance before:
3.6714 +- 0.20% Gcycles
3.6620 +- 0.12% Gcycles
3.6704 +- 0.26% Gcycles
3.6602 +- 0.27% Gcycles
3.6799 +- 0.37% Gcycles
after:
3.6540 +- 0.30% Gcycles
3.6388 +- 0.25% Gcycles
3.6557 +- 0.17% Gcycles
3.6449 +- 0.15% Gcycles
3.6460 +- 0.26% Gcycles
(every line is a different `profile-build` and shows the number of
cycles needed for `./stockfish bench`, measured with `perf stat -r 10`)
closes https://github.com/official-stockfish/Stockfish/pull/5754
No functional change
2025-02-13 19:44:53 +01:00
Shawn Xu
d66e603070
Increase PCM bonus when cutOffCnt is low
...
Passed STC:
LLR: 2.95 (-2.94,2.94) <0.00,2.00>
Total: 36832 W: 9763 L: 9438 D: 17631
Ptnml(0-2): 159, 4267, 9254, 4562, 174
https://tests.stockfishchess.org/tests/view/67a29dbafedef70e42ac329a
Passed LTC:
LLR: 2.95 (-2.94,2.94) <0.50,2.50>
Total: 19728 W: 5124 L: 4839 D: 9765
Ptnml(0-2): 18, 2029, 5485, 2314, 18
https://tests.stockfishchess.org/tests/view/67a2a1abfedef70e42ac32b7
closes https://github.com/official-stockfish/Stockfish/pull/5865
Bench: 3197798
2025-02-05 19:00:25 +01:00
Daniel Monroe
3dfbc5de25
Remove non-pawn material check in qsearch pruning
...
Passed simplification STC
LLR: 2.96 (-2.94,2.94) <-1.75,0.25>
Total: 47712 W: 12621 L: 12409 D: 22682
Ptnml(0-2): 224, 5349, 12480, 5597, 206
https://tests.stockfishchess.org/tests/view/67a1b4fb612069de394afc37
Passed rebased simplification LTC
LLR: 2.95 (-2.94,2.94) <-1.75,0.25>
Total: 188274 W: 47727 L: 47677 D: 92870
Ptnml(0-2): 171, 20429, 52867, 20519, 151
https://tests.stockfishchess.org/tests/view/67a2a761fedef70e42ac3300
closes https://github.com/official-stockfish/Stockfish/pull/5866
bench 2654242
2025-02-05 18:56:12 +01:00
Disservin
4c6d2bf921
Show stdout/stderr in CI/CD tests
...
makes it easier to fix based on warnings shown with e.g. valgrind
closes https://github.com/official-stockfish/Stockfish/pull/5862
No functional change
2025-02-05 18:52:28 +01:00
Disservin
2a5b41fd12
Fixes a wrongly combined merge conflict from the previous merge wave.
...
Passed STC:
https://tests.stockfishchess.org/tests/view/67a288aaeb183d11c65945f1
LLR: 2.99 (-2.94,2.94) <0.00,2.00>
Total: 51424 W: 13588 L: 13237 D: 24599
Ptnml(0-2): 223, 6039, 12860, 6344, 246
Passed LTC:
https://tests.stockfishchess.org/tests/view/67a28c0aeb183d11c6594609
LLR: 2.94 (-2.94,2.94) <0.50,2.50>
Total: 54144 W: 13900 L: 13543 D: 26701
Ptnml(0-2): 42, 5881, 14870, 6236, 43
closes https://github.com/official-stockfish/Stockfish/pull/5863
Bench: 2345723
2025-02-04 23:08:43 +01:00
Michael Chaly
e852d9880a
Reduce less for positions without tt move
...
Continuation of work on scaling.
In line with previous scaling patches this one massively reduces
reduction for moves that don't go thru lmr for position without a tt
move.
Passed VVLTC with STC bounds:
https://tests.stockfishchess.org/tests/view/679fd2450774dfd78deb12b2
LLR: 2.94 (-2.94,2.94) <0.00,2.00>
Total: 74718 W: 19354 L: 19042 D: 36322
Ptnml(0-2): 5, 6724, 23595, 7024, 11
Passed VVLTC with LTC bounds:
https://tests.stockfishchess.org/tests/view/67a009930774dfd78deb2346
LLR: 2.94 (-2.94,2.94) <0.50,2.50>
Total: 82638 W: 21587 L: 21212 D: 39839
Ptnml(0-2): 15, 7476, 25953, 7869, 6
closes https://github.com/official-stockfish/Stockfish/pull/5860
Bench: 2887850
2025-02-04 21:37:11 +01:00
FauziAkram
67573218e1
VVLTC parameters tweak
...
Some notes:
- Both tests were conducted on top of #5848 .
- Based on tuning suggestions, the extension for capturing the
previously moved piece was removed/simplified. (Developers can attempt
to reintroduce it post-merge if needed.)
- Initially, bonusScale = std::max(bonusScale, -2); was included but
later removed in the second test upon Viz's request, however, it was
nearly non-functional anyway.
Passed VVLTC under STC bounds:
LLR: 2.95 (-2.94,2.94) <0.00,2.00>
Total: 31508 W: 8153 L: 7895 D: 15460
Ptnml(0-2): 1, 2747, 10005, 2995, 6
https://tests.stockfishchess.org/tests/view/679fdc7a0774dfd78deb1350
Passed VVLTC under LTC bounds:
LLR: 2.94 (-2.94,2.94) <0.50,2.50>
Total: 55026 W: 14370 L: 14046 D: 26610
Ptnml(0-2): 7, 4957, 17262, 5279, 8
https://tests.stockfishchess.org/tests/view/679fec920774dfd78deb19b8
closes https://github.com/official-stockfish/Stockfish/pull/5856
Bench: 2757788
2025-02-04 21:34:08 +01:00
Viren6
ec7f1d6229
Increment cutoffCnt less often after fail high
...
Only increment when extension is less than 2 or it's a PvNode.
Tested vs #5851 .
Failed STC:
LLR: -2.97 (-2.94,2.94) <0.00,2.00>
Total: 360064 W: 94546 L: 94271 D: 171247
Ptnml(0-2): 1835, 42826, 90314, 43343, 1714
https://tests.stockfishchess.org/tests/view/679f79cc0774dfd78deb1112
Passed LTC:
LLR: 2.94 (-2.94,2.94) <0.00,2.00>
Total: 443076 W: 113942 L: 113081 D: 216053
Ptnml(0-2): 480, 49076, 121579, 49909, 494
https://tests.stockfishchess.org/tests/view/679fa21b0774dfd78deb1178
Passed VLTC:
LLR: 2.94 (-2.94,2.94) <0.50,2.50>
Total: 187184 W: 48098 L: 47495 D: 91591
Ptnml(0-2): 59, 19036, 54792, 19653, 52
https://tests.stockfishchess.org/tests/view/679fb6000774dfd78deb11e8
closes https://github.com/official-stockfish/Stockfish/pull/5855
Bench: 3018089
2025-02-04 21:30:54 +01:00
Michael Chaly
3b8bfeb38a
Do less aggressive pruning for higher movecounts
...
Move part of heuristic that makes reduction less before pruning stage.
Passed STC:
https://tests.stockfishchess.org/tests/view/679fdf1b0774dfd78deb13b3
LLR: 2.93 (-2.94,2.94) <0.00,2.00>
Total: 47136 W: 12484 L: 12146 D: 22506
Ptnml(0-2): 211, 5472, 11866, 5806, 213
Passed LTC:
https://tests.stockfishchess.org/tests/view/679fe6790774dfd78deb1753
LLR: 2.94 (-2.94,2.94) <0.50,2.50>
Total: 100536 W: 25837 L: 25383 D: 49316
Ptnml(0-2): 103, 10990, 27622, 11456, 97
closes https://github.com/official-stockfish/Stockfish/pull/5853
Bench: 3265587
2025-02-04 21:28:49 +01:00
Kenneth Lee
09623abbe8
Simplify cutoffCnt further
...
Based off [Simplify cutoffCnt](69be04d38ea77a895c3bhttps://tests.stockfishchess.org/tests/view/679edb7c0774dfd78deb0eed
Passed LTC:
LLR: 2.95 (-2.94,2.94) <-1.75,0.25>
Total: 267198 W: 68148 L: 68179 D: 130871
Ptnml(0-2): 232, 30051, 73055, 30038, 223
https://tests.stockfishchess.org/tests/view/679ef2c70774dfd78deb0f43
closes https://github.com/official-stockfish/Stockfish/pull/5851
Bench: 3119355
2025-02-04 21:26:04 +01:00
Nonlinear2
9ed1725e78
Simplify bonusScale formula
...
Passed STC:
https://tests.stockfishchess.org/tests/view/679ea7bc0774dfd78deb0d68
LLR: 2.93 (-2.94,2.94) <-1.75,0.25>
Total: 47680 W: 12575 L: 12364 D: 22741
Ptnml(0-2): 179, 5589, 12139, 5708, 225
Passed LTC:
https://tests.stockfishchess.org/tests/view/679eb7760774dfd78deb0dbb
LLR: 2.96 (-2.94,2.94) <-1.75,0.25>
Total: 314220 W: 80110 L: 80189 D: 153921
Ptnml(0-2): 265, 35121, 86420, 35036, 268
closes https://github.com/official-stockfish/Stockfish/pull/5849
Bench: 3161782
2025-02-04 21:24:06 +01:00
Nonlinear2
fccc6f624e
Reduce full depth search twice
...
Passed STC:
https://tests.stockfishchess.org/tests/view/679f429e0774dfd78deb10a5
LLR: 2.95 (-2.94,2.94) <0.00,2.00>
Total: 71584 W: 18905 L: 18529 D: 34150
Ptnml(0-2): 302, 8372, 18081, 8722, 315
Passed LTC:
https://tests.stockfishchess.org/tests/view/679f72a00774dfd78deb1102
LLR: 2.94 (-2.94,2.94) <0.50,2.50>
Total: 353952 W: 91007 L: 90024 D: 172921
Ptnml(0-2): 375, 39163, 96921, 40138, 379
closes https://github.com/official-stockfish/Stockfish/pull/5848
Bench: 3642363
2025-02-04 21:22:08 +01:00
Disservin
c12dbdedd9
Disallow same option being added twice
...
Now exits during startup.
```
./stockfish
Stockfish dev-20250202-243c7c6a by the Stockfish developers (see AUTHORS file)
x1,5,0,10,0.5,0.0020
Option: "x1" was already added!
```
i.e. prevents and helps debug this case
```cpp
int x1 = 5;
TUNE(x1);
TUNE(x1);
```
closes https://github.com/official-stockfish/Stockfish/pull/5847
No functional change
2025-02-04 21:18:01 +01:00
Shawn Xu
8c73472ac8
Simplify depth increase condition further
...
Passed Non-regression STC:
LLR: 2.95 (-2.94,2.94) <-1.75,0.25>
Total: 51232 W: 13560 L: 13351 D: 24321
Ptnml(0-2): 183, 6075, 12920, 6226, 212
https://tests.stockfishchess.org/tests/view/679d7b2b0774dfd78deb043f
Passed Non-regression LTC (v. #5827 ):
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 172398 W: 44108 L: 44042 D: 84248
Ptnml(0-2): 122, 19207, 47489, 19245, 136
https://tests.stockfishchess.org/tests/view/679d7fb10774dfd78deb05d2
Passed Non-regression VLTC (v. #5827 ):
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 388540 W: 99314 L: 99464 D: 189762
Ptnml(0-2): 89, 40454, 113350, 40272, 105
https://tests.stockfishchess.org/tests/view/679da3be0774dfd78deb0ad4
closes https://github.com/official-stockfish/Stockfish/pull/5846
Bench: 2688175
2025-02-04 21:11:37 +01:00
Guenther Demetz
2a1ab11ab0
Micro-optimization for SEE: remove a superfluous condition
...
This condition can never be true, it's superfluous.
It never triggers even with a bench 16 1 20 run.
To met the condition it would imply that the previous recapture was done
by a higher rated piece than a Queen.
This is only the case when the King recaptures and that's already
handled in line 1161: (return (attackers & ~pieces(stm)) ? res ^ 1).
closes https://github.com/official-stockfish/Stockfish/pull/5839
No functional change
2025-02-04 21:11:05 +01:00
Robert Nurnberg @ elitebook
d46c0b6f49
Add cursed win checks to CI matetrack tests
...
This PR adds a run for the `matecheck.py` script from the matetrack repo
with the option `--syzygy50MoveRule false`.
The new tests guard against a re-introduction of the bugs recently fixed
by https://github.com/official-stockfish/Stockfish/pull/5814 .
closes https://github.com/official-stockfish/Stockfish/pull/5829
No functional change
2025-02-02 13:54:04 +01:00
Kenneth Lee
9f0844c101
Simplify extensions depth increase condition
...
Passed STC:
LLR: 2.95 (-2.94,2.94) <-1.75,0.25>
Total: 42784 W: 11198 L: 10979 D: 20607
Ptnml(0-2): 166, 5024, 10822, 5185, 195
https://tests.stockfishchess.org/tests/view/6795b6f8f6281b7d7b1869d6
Failed LTC:
LLR: -2.95 (-2.94,2.94) <-1.75,0.25>
Total: 283614 W: 72046 L: 72587 D: 138981
Ptnml(0-2): 241, 32097, 77647, 31606, 216
https://tests.stockfishchess.org/tests/view/6795cbb6f6281b7d7b186a07
Passed VLTC:
LLR: 2.94 (-2.94,2.94) <-1.75,0.25>
Total: 59678 W: 15387 L: 15211 D: 29080
Ptnml(0-2): 23, 6169, 17273, 6357, 17
https://tests.stockfishchess.org/tests/view/6795c6dbf6281b7d7b1869f9
closes https://github.com/official-stockfish/Stockfish/pull/5827
Bench: 3088494
2025-02-02 13:52:16 +01:00
Disservin
65a9a391e9
Silence clang-format issue
...
No functional change
2025-02-02 13:49:54 +01:00
Michael Chaly
dabffbceff
Make pruning at ttpv nodes more aggressive
...
Continuation of work done by @FauziAkram and @Viren6 They had a series
of patches that decrease pruning for ttPv nodes - and it passed as a
gainer at lower time controls while revert passed as a gainer at higher
time controls.
So it's a logical continuation of this work that increases pruning for
ttPv nodes in hopes of scaling to longer TCs.
Fixed games STC:
https://tests.stockfishchess.org/tests/view/679ee3910774dfd78deb0efd
Elo: -4.98 ± 2.1 (95%) LOS: 0.0%
Total: 28584 W: 7229 L: 7639 D: 13716
Ptnml(0-2): 143, 3579, 7219, 3247, 104
nElo: -9.54 ± 4.0 (95%) PairsRatio: 0.90
Passed VVLTC with STC bounds:
https://tests.stockfishchess.org/tests/view/679d21f70774dfd78deaf553
LLR: 2.94 (-2.94,2.94) <0.00,2.00>
Total: 323282 W: 83729 L: 83105 D: 156448
Ptnml(0-2): 37, 29842, 101269, 30446, 47
Passed VVLTC with LTC bounds:
https://tests.stockfishchess.org/tests/view/679e7a970774dfd78deb0cd3
LLR: 2.95 (-2.94,2.94) <0.50,2.50>
Total: 113712 W: 29485 L: 29051 D: 55176
Ptnml(0-2): 13, 10376, 35640, 10818, 9
closes https://github.com/official-stockfish/Stockfish/pull/5844
Bench: 2964045
2025-02-02 13:47:52 +01:00
