Small formatting improvements

Changes some C style casts to C++ style, and fixes some incorrect comments and variable names.

closes #4845

No functional change
This commit is contained in:
cj5716
2023-10-24 07:43:49 +08:00
committed by Joost VandeVondele
parent 49ece9f791
commit d6a5c2b085
5 changed files with 16 additions and 16 deletions

View File

@@ -116,7 +116,7 @@ static bool read_header(std::istream& stream, std::uint32_t* hashValue, std::str
static bool write_header(std::ostream& stream, std::uint32_t hashValue, const std::string& desc) {
write_little_endian<std::uint32_t>(stream, Version);
write_little_endian<std::uint32_t>(stream, hashValue);
write_little_endian<std::uint32_t>(stream, (std::uint32_t) desc.size());
write_little_endian<std::uint32_t>(stream, std::uint32_t(desc.size()));
stream.write(&desc[0], desc.size());
return !stream.fail();
}

View File

@@ -93,7 +93,7 @@ class SqrClippedReLU {
output[i] = static_cast<OutputType>(
// Really should be /127 but we need to make it fast so we right shift
// by an extra 7 bits instead. Needs to be accounted for in the trainer.
std::min(127ll, ((long long) input[i] * input[i]) >> (2 * WeightScaleBits + 7)));
std::min(127ll, ((long long) (input[i]) * input[i]) >> (2 * WeightScaleBits + 7)));
}
}
};

View File

@@ -130,11 +130,11 @@ inline void write_little_endian(std::ostream& stream, IntType value) {
{
for (; i + 1 < sizeof(IntType); ++i)
{
u[i] = (std::uint8_t) v;
u[i] = std::uint8_t(v);
v >>= 8;
}
}
u[i] = (std::uint8_t) v;
u[i] = std::uint8_t(v);
stream.write(reinterpret_cast<char*>(u), sizeof(IntType));
}