mirror of
https://github.com/HChaZZY/Stockfish.git
synced 2025-12-20 17:16:33 +08:00
Fix endless reaparenting loop
The check for detecting when a split point has all the slaves still running is done with: slavesMask == allSlavesMask When a thread reparents, slavesMask is increased, then, if the same thread finishes, because there are no more moves, slavesMask returns to original value and the above condition returns to be true. So that the just finished thread immediately reparents again with the same split point, then starts and then immediately exits in a tight loop that ends only when a second slave finishes, so that slavesMask decrements and the condition becomes false. This gives a spurious and anomaly high number of faked reparents. With this patch, that rewrites the logic to avoid this pitfall, the reparenting success rate drops to a more realistical 5-10% for 4 threads case. As a side effect note that now there is no more the limit of maxThreadsPerSplitPoint when reparenting. No functional change. Signed-off-by: Marco Costalba <mcostalba@gmail.com>
This commit is contained in:
@@ -51,13 +51,13 @@ struct SplitPoint {
|
||||
// Shared data
|
||||
Lock lock;
|
||||
volatile uint64_t slavesMask;
|
||||
volatile uint64_t allSlavesMask;
|
||||
volatile int64_t nodes;
|
||||
volatile Value alpha;
|
||||
volatile Value bestValue;
|
||||
volatile Move bestMove;
|
||||
volatile int moveCount;
|
||||
volatile bool cutoff;
|
||||
volatile bool allSlavesRunning;
|
||||
};
|
||||
|
||||
|
||||
|
||||
Reference in New Issue
Block a user