mirror of
https://github.com/HChaZZY/Stockfish.git
synced 2025-12-19 16:46:30 +08:00
Don't lock before check for termination
Restore old locking scheme changed with
commit 1e92df6b20.
This seems to prevent a very rare crash that occurs
once every 5-10K games.
With this patch we have no crashes after 33K games.
Signed-off-by: Marco Costalba <mcostalba@gmail.com>
This commit is contained in:
@@ -2158,17 +2158,16 @@ void Thread::idle_loop(SplitPoint* sp) {
|
||||
{
|
||||
assert((!sp && threadID) || Threads.use_sleeping_threads());
|
||||
|
||||
// Grab the lock to avoid races with Thread::wake_up()
|
||||
lock_grab(&sleepLock);
|
||||
|
||||
// Slave thread should exit as soon as do_terminate flag raises
|
||||
if (do_terminate)
|
||||
{
|
||||
assert(!sp);
|
||||
lock_release(&sleepLock);
|
||||
return;
|
||||
}
|
||||
|
||||
// Grab the lock to avoid races with Thread::wake_up()
|
||||
lock_grab(&sleepLock);
|
||||
|
||||
// If we are master and all slaves have finished don't go to sleep
|
||||
if (sp && all_slaves_finished(sp))
|
||||
{
|
||||
|
||||
Reference in New Issue
Block a user