HCha/Stockfish
1
0
Fork 0
mirror of https://github.com/HChaZZY/Stockfish.git synced 2025-12-19 08:36:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

After a "stop" do not read new input until search finishes

Browse Source 
Unfortunatly xboard sends immediately the new position to
search after sending "stop" when we have a ponder miss.

Becuase main thread position is not copied but is referenced
directly from root position and the latter is modified by
the "position.." UCI command we end up with the working position
that changes under our feet while the search is still recovering
after the "stop" and this causes a crash.

This happens only with the (broken) xboard, native UCI does not
have this problem.

Reported by otello1984

No functional change.

Signed-off-by: Marco Costalba <mcostalba@gmail.com>
This commit is contained in:
Marco Costalba
2011-11-27 12:16:23 +01:00
parent ffa75215cc
commit 6809b57cfc
3 changed files with 22 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/thread.cpp
View File

@@ -423,6 +423,23 @@ void Thread::main_loop() {
}
// ThreadsManager::wait_end_of_search() blocks UI thread until main thread has
// returned to sleep in main_loop(). It is needed becuase xboard sends immediately
// new position to search after a "stop" due to ponder miss.
void ThreadsManager::wait_end_of_search() {
Thread& main = threads[0];
lock_grab(&main.sleepLock);
while (!main.do_sleep)
cond_wait(&sleepCond, &main.sleepLock);
lock_release(&main.sleepLock);
}
// ThreadsManager::start_thinking() is used by UI thread to wake up the main
// thread parked in main_loop() and starting a new search. If asyncMode is true
// then function returns immediately, otherwise caller is blocked waiting for
@@ -432,11 +449,10 @@ void ThreadsManager::start_thinking(bool asyncMode) {
Thread& main = threads[0];
lock_grab(&main.sleepLock);
// Wait main thread has finished before to launch a new search
while (!main.do_sleep)
cond_wait(&sleepCond, &main.sleepLock);
wait_end_of_search();
lock_grab(&main.sleepLock);
// Reset signals before to start the search
memset((void*)&Search::Signals, 0, sizeof(Search::Signals));