mirror of
https://github.com/HChaZZY/Stockfish.git
synced 2025-12-20 00:56:39 +08:00
Use spinlock instead of mutex for Threads and SplitPoint
It is reported to be defenitly faster with increasing number of threads, we go from a +3.5% with 4 threads to a +15% with 16 threads. The only drawback is that now when testing with more threads than physical available cores, the speed slows down to a crawl. This is expected and was similar at what we had setting the old sleepingThreads to false. No functional change.
This commit is contained in:
@@ -165,8 +165,8 @@ void Thread::split(Position& pos, Stack* ss, Value alpha, Value beta, Value* bes
|
||||
// Try to allocate available threads and ask them to start searching setting
|
||||
// 'searching' flag. This must be done under lock protection to avoid concurrent
|
||||
// allocation of the same slave by another master.
|
||||
Threads.mutex.lock();
|
||||
sp.mutex.lock();
|
||||
Threads.spinlock.acquire();
|
||||
sp.spinlock.acquire();
|
||||
|
||||
sp.allSlavesSearching = true; // Must be set under lock protection
|
||||
++splitPointsSize;
|
||||
@@ -188,8 +188,8 @@ void Thread::split(Position& pos, Stack* ss, Value alpha, Value beta, Value* bes
|
||||
// it will instantly launch a search, because its 'searching' flag is set.
|
||||
// The thread will return from the idle loop when all slaves have finished
|
||||
// their work at this split point.
|
||||
sp.mutex.unlock();
|
||||
Threads.mutex.unlock();
|
||||
sp.spinlock.release();
|
||||
Threads.spinlock.release();
|
||||
|
||||
Thread::idle_loop(); // Force a call to base class idle_loop()
|
||||
|
||||
@@ -202,8 +202,8 @@ void Thread::split(Position& pos, Stack* ss, Value alpha, Value beta, Value* bes
|
||||
// We have returned from the idle loop, which means that all threads are
|
||||
// finished. Note that setting 'searching' and decreasing splitPointsSize must
|
||||
// be done under lock protection to avoid a race with Thread::available_to().
|
||||
Threads.mutex.lock();
|
||||
sp.mutex.lock();
|
||||
Threads.spinlock.acquire();
|
||||
sp.spinlock.acquire();
|
||||
|
||||
searching = true;
|
||||
--splitPointsSize;
|
||||
@@ -213,8 +213,8 @@ void Thread::split(Position& pos, Stack* ss, Value alpha, Value beta, Value* bes
|
||||
*bestMove = sp.bestMove;
|
||||
*bestValue = sp.bestValue;
|
||||
|
||||
sp.mutex.unlock();
|
||||
Threads.mutex.unlock();
|
||||
sp.spinlock.release();
|
||||
Threads.spinlock.release();
|
||||
}
|
||||
|
||||
|
||||
|
||||
Reference in New Issue
Block a user